On 2018/07/27 13:38, Brian Callahan wrote:
>
> On 07/27/18 13:00, Elias M. Mariani wrote:
> > Good quality in your port, I would even say if this is your first
> > port... too good to be true, must find something to criticize...
> > Your mail has poor formatting, +80 chars. long on some lines. (?)
> > Just a joke, good work, clearly you took the job of porting this
> > seriously enough, good luck with the rest of the dependencies of
> > Qflow!
> >
> > Cheers.
> > Elias.
> >
> > 2018-07-27 11:11 GMT-03:00 Alessandro DE LAURENZIS
> > <jus...@atlantide.t28.net>:
> > > Dear ports@ readers,
> > >
> > > as first follow-up of my previous e-mail, enclosed please find the port
> > > for
> > > abc [1]:
> > >
> > > [... snip ...]
> > > ABC: A System for Sequential Synthesis and Verification
> > >
> > > ABC is a growing software system for synthesis and verification of binary
> > > sequential logic circuits appearing in synchronous hardware designs. ABC
> > > combines scalable logic optimization based on And-Inverter Graphs (AIGs),
> > > optimal-delay DAG-based technology mapping for look-up tables and standard
> > > cells, and innovative algorithms for sequential synthesis and
> > > verification.
> > > [... snip ...]
> > >
> > > It compiles flawlessly and runs as expected (tested on amd64 only, for a
> > > limited set of test-cases, no test suite available).
> > >
> > > We only need to patch the Makefile, in order to correctly set the compiler
> > > option when the __OpenBSD__ identifier is found.
> > >
> > > Please consider that this is my first attempt to build a quality level
> > > port,
> > > so please have a careful look at it and let me know your comments.
> > >
> > > Of course, I step-up for maintainership.
> > >
> > > [1] https://people.eecs.berkeley.edu/~alanmi/abc/
> > >
> > > --
> > > Alessandro DE LAURENZIS
> > > [mailto:jus...@atlantide.t28.net]
> > > Web: http://www.atlantide.t28.net
> > > LinkedIn: http://it.linkedin.com/in/delaurenzis
>
> You need a MAKE_FLAGS line:
> MAKE_FLAGS= CC="${CC}" CXX="${CXX}" ABC_MAKE_VERBOSE=1 OPTFLAGS=
> to set the compiler correctly, remove an -O flag, and enable verbose
> compiling.
>
> There are also some warnings that you should take care of. And please
> upstream your patches.
>
> All you need for the do-install routine is
> ${INSTALL_PROGRAM} ${WRKSRC}/abc ${PREFIX}/bin
>
> So much whitespace. You can reel everything in a tab.
>
> The correct WANTLIB line is
> WANTLIB += ${COMPILER_LIBCXX} c curses m readline
>
> License marker should just be MIT.
>
> ~Brian
>
There are some hardcoded /usr/local in the upstream Makefiles as well
which should be replaced with ${LOCALBASE} and use ${SUBST_CMD} on the files.
