Didn't mean to top post, was still at the PC when I saw Stuart's replay.
I have attached a diff of the DESCR file based on the recommended
changes. Should I have packed up another tarball since only one file is
being changed here?
Does everything look in order with this?
Edward Lopez-Acosta
On 8/25/18 9:03 PM, Jeremie Courreges-Anglas wrote:
(Please avoid top-posting.)
On Sat, Aug 25 2018, Edward Lopez-Acosta <elopezaco...@gmail.com> wrote:
On 8/25/18 4:21 PM, Stuart Henderson wrote:
On 2018/08/25 15:43, Edward Lopez-Acosta wrote:
Hello,
I am working on porting the larger cookiecutter project and this is one of
the required modules.
This port is for the binaryornot python module needed for the cookiecutter
application. It checks a specified file based on heuristic data and is
similar to Perl's pp_fttext, and is lightweight.
All tests pass and I am able to build it for both py2 and py3 on amd64.
No current ports depend on this module.
Any changes needed or can it be merged please?
--
Edward Lopez-Acosta
You have a ${MODPY_COMMENT} on a line which shouldn't have one, and don't
have one on
"lib/python${MODPY_VERSION}/site-packages/binaryornot/${MODPY_PYCACHE}"
which should be present (haven't tested but I would expect packaging to fail
for py2).
PLIST fixed and new tarball attached.
Verified both py2 and py3 `make package` works without error.
DESCR appears to be copy-pasted, the last two parapgraphs sound
superfluous to me, and the "Has tests for these file types:" list
should probably mention "text" and "binary" on their own lines.
Actually I would only keep the first paragraph, since syncing that list
when upgrading to newer versions doesn't look like a good idea in the
long run.
Aaaaand what is "@eliben" supposed to mean? https://twitter.com/eliben
doesn't look like Eli Bendersky's twitter account.
Except for this, LGTM.
--- DESCR.orig Sun Aug 26 11:40:21 2018
+++ DESCR Sun Aug 26 11:41:33 2018
@@ -1,15 +1,3 @@
Ultra-lightweight pure Python package to guess whether a file is binary or
-text, using a heuristic similar to Perl's `pp_fttext` and its analysis by
-@eliben.
-
-Has tests for these file types:
-
-* Text: .txt, .css, .json, .svg, .js, .lua, .pl, .rst * Binary: .png, .gif,
-.jpg, .tiff, .bmp, .DS_Store, .eot, .otf, .ttf, .woff, .rgb
-
-You may be thinking, "I can write this in 2 lines of code?!" It's actually not
-that easy. Over time, more edge cases have been found and our heuristic has
-gotten more complex.
-
-Also, this package saves you from having to write and thoroughly test your code
-with all sorts of weird file types and encodings, and is cross-platform.
+text, using a heuristic similar to Perl's `pp_fttext`. This package is
+cross platform and works with a variety of file types and encodings.
