On Wed, Dec 19 2018, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > On Wed, Dec 19 2018, Ed Hynan <eh_l...@optonline.net> wrote: >> net/wmnetload has a memory leak [patch] >> >> wmnetload (6.4 release) repeatedly calls getifaddrs(3) >> without freeifaddrs. > > Indeed. > >> The patch here fixes and would replace >> net/wmnetload/patches/patch-src_ifstat_openbsd_c >> not apply over it. > > Thanks. If you want to make it easier for people to pick up your > patches, please try to submit patches using make update-patches and cvs > diff. For more information on how to use update-patches, see item 11: > > https://www.openbsd.org/faq/ports/guide.html > > Since the fix changes what ends up in the package, it should include > a REVISION bump. > >> Also fixes a compile warning from strcmp() w/o <string.h> > > Yep. > > Here's a reworked version, not directly based on your diff. There's no > need to keep around what getifaddrs(3) returns, we can always free it. > This simplifies the memory management and appears to fix the memory leak > in the current package. I have no idea if wmnetload actually works, it > seems to just draw an empty black window under my window manager. > > Could you please test this and report back?
Thanks to sthen@ I could test that the port still behaves properly (need to use -w to run in windowed mode). The fix has been committed. Thanks, -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
