On Wed, 19 Dec 2018, Jeremie Courreges-Anglas wrote: > On Wed, Dec 19 2018, Ed Hynan <eh_l...@optonline.net> wrote: > > net/wmnetload has a memory leak [patch] > > > > wmnetload (6.4 release) repeatedly calls getifaddrs(3) > > without freeifaddrs. > > Indeed. > > > The patch here fixes and would replace > > net/wmnetload/patches/patch-src_ifstat_openbsd_c > > not apply over it. > > Thanks. If you want to make it easier for people to pick up your > patches, please try to submit patches using make update-patches and cvs > diff. For more information on how to use update-patches, see item 11: > > https://www.openbsd.org/faq/ports/guide.html > > Since the fix changes what ends up in the package, it should include > a REVISION bump.
OK. I was concerned that I have 6.4 release and my ports are cvs checkout -P -rOPENBSD_6_4 ports -- is this what ports folks are working on? (probably wouldn't matter with this package, but...) > > > Also fixes a compile warning from strcmp() w/o <string.h> > > Yep. > > Here's a reworked version, not directly based on your diff. There's no > need to keep around what getifaddrs(3) returns, we can always free it. > This simplifies the memory management and appears to fix the memory leak > in the current package. I have no idea if wmnetload actually works, it > seems to just draw an empty black window under my window manager. > > Could you please test this and report back? It's fine here. (I see your latest msg re. -w; pardon my late response.) -Ed Hynan [snip quoted patch]
