Dear ports@ readers,
from the last landry@'s sparc64 bulk build report (see [1]), I noticed
that cad/netgen was failing.
I think the reason is the "-std=c89" flag that I added to reduce the
noise during compile, hiding a bunch of this kind of messages:
warning: implicit declaration of function 'xxx' is invalid in C99
The problem is that in some files the "//" comment style has been used
(and it isn't allowed in ANSI C - don't know why clang isn't complaining).
We can simply use a more specific flag
(-Wno-implicit-function-declaration" to obtain the same effect.
I don't have a sparc64 station, so I'm asking for confirmation.
I'm not entirely sure that we need a revision bump; if not, just let me
know and I'll amend the diff.
[1] https://marc.info/?l=openbsd-ports&m=155686934021110&w=2
--
Alessandro DE LAURENZIS
[mailto:jus...@atlantide.t28.net]
Web: http://www.atlantide.t28.net
LinkedIn: https://www.linkedin.com/in/delaurenzis/
Index: Makefile
===================================================================
RCS file: /cvs/ports/cad/netgen/Makefile,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 Makefile
--- Makefile 28 Apr 2019 20:51:27 -0000 1.2
+++ Makefile 5 May 2019 07:07:45 -0000
@@ -3,7 +3,7 @@
COMMENT = tool for netlist comparison (LVS) and format manipulation
DISTNAME = netgen-1.5.118
EXTRACT_SUFX = .tgz
-REVISION = 0
+REVISION = 1
CATEGORIES = cad
@@ -31,7 +31,7 @@ PATCHORIG = .patch.orig
WRKCONF = ${WRKSRC}/scripts
CONFIGURE_STYLE = gnu
CONFIGURE_ENV = CPPFLAGS="-I${X11BASE}/include" \
- CFLAGS="-std=c89 ${CFLAGS}"
+ CFLAGS="-Wno-implicit-function-declaration ${CFLAGS}"
CONFIGURE_ARGS = --with-tcl=${MODTCL_LIBDIR} \
--with-tk=${MODTK_LIBDIR}
