On Fri, May 10 2019, Timothy Brown <tbr...@freeshell.org> wrote:
> On Thu, May 09, 2019 at 04:42:08PM -0600, Timothy Brown wrote:
>> On Wed, May 08, 2019 at 11:53:24AM -0400, Jeremie Courreges-Anglas wrote:
>> > 
>> > My first thought was: "why add a FLAVOR?".  If gpg/gpgme support is the
>> > only way to avoid the need of plaintext credentials, maybe it should be
>> > enabled by default?
>> > 
>> 
>> Very good question. I was thinking more for backwards compatibility,
>> however that is still satisfied even if it is built with gpg/gpgme.
>> So the only reason I can think of is to keep the dependencies down,
>> although that seems like a silly excuse for such a small list of
>> added dependencies.
>> 
>> I'll re-do the patch with gpg/gpgme include without offering a flavor.
>> 
>
> New patch generated without any FLAVOURS.
>
> Thoughts, OK?

LGTM ports-wise.  Maybe Stuart has another opinion?

NB: I did not review the usage of pledge()

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to