On 2019/06/11 16:16, Jonathan Gray wrote: > On Mon, Jun 10, 2019 at 10:34:21PM +0200, Klemens Nanni wrote: > > On Mon, Jun 10, 2019 at 08:10:58PM +0100, Stuart Henderson wrote: > > > Removing execinfo from WANTLIB nullifies the devel/libexecinfo > > > LIB_DEPENDS .. > > That... is a valid point. I'll leave it in and double check tooling's > > output before cooking diffs, thanks. > > I don't see why you are removing libcurses and libz from wantlib > > $ ldd /usr/local/bin/include-what-you-use > /usr/local/bin/include-what-you-use: > Start End Type Open Ref GrpRef Name > 0000050a920fd000 0000050a9352b000 exe 2 0 0 > /usr/local/bin/include-what-you-use > 0000050d4ff04000 0000050d4ff11000 rlib 0 2 0 > /usr/lib/libpthread.so.26.1 > 0000050d8fd16000 0000050d939de000 rlib 0 1 0 > /usr/local/lib/libLLVM-7.so > 0000050d0ced0000 0000050d0cfc2000 rlib 0 2 0 > /usr/lib/libc++.so.2.2 > 0000050d17810000 0000050d17853000 rlib 0 3 0 > /usr/lib/libc++abi.so.0.1 > 0000050d68782000 0000050d687b1000 rlib 0 2 0 > /usr/lib/libm.so.10.1 > 0000050d1e240000 0000050d1e336000 rlib 0 1 0 > /usr/lib/libc.so.95.1 > 0000050d45d6c000 0000050d45da9000 rlib 0 1 0 > /usr/lib/libedit.so.5.2 > 0000050d1cbec000 0000050d1cc07000 rlib 0 1 0 > /usr/lib/libz.so.5.0 > 0000050d62d77000 0000050d62dd9000 rlib 0 1 0 > /usr/lib/libcurses.so.14.0 > 0000050d1a310000 0000050d1a310000 ld.so 0 1 0 > /usr/libexec/ld.so
Ports WANTLIB lines only list things linked directly to files in that port, not things pulled in via library dependencies. $ objdump -p /usr/local/bin/include-what-you-use | grep NEEDED NEEDED libpthread.so.26.1 NEEDED libLLVM-7.so NEEDED libc++.so.2.2 NEEDED libc++abi.so.0.1 NEEDED libm.so.10.1 NEEDED libc.so.95.1 I think it's correct to remove those extras. libexecinfo is an extra specially annoying case because many ports are only prepared to deal with Linux (execinfo.h header but the backtrace functions are in libc). I'm not sure where it originally came from in the i-w-y-u port but reviewing the source/build infrastructure there is nothing that uses it, so we are ok to remove this from the port too (LIB_DEPENDS as well as the WANTLIB).
