On 2019/11/18 21:28, Stuart Henderson wrote: > On 2019/11/18 22:19, Tim Kuijsten wrote: > > Here is a new updated port of wiresep based on v0.8.3. > > > > It incorporates all the feedback I got: > > * don't change the process name, keep wiresep > > * let resource limits take the configuration into account > > (fixes a pre-mature exit of the enclave on the octeon platform) > > * treat OOM errors in the main loop as transient > > * don't notify proxy to destroy unsent sessions > > > > Thanks Bjorn, Janne and Stuart for all the feedback! > > > > Stuart Henderson <s...@spacehopper.org> wrote: > > > On 2019/11/18 18:42, Tim Kuijsten wrote: > > > > > Btw, could we make the proctitle slightly nicer on the cpu-bearing > > > > > process? > > > > > > > > > > PID USERNAME PRI NICE SIZE RES STATE WAIT TIME CPU > > > > > COMMAND > > > > > 19404 wsep 39 0 1440K 3232K onproc/1 - 0:07 27.88% > > > > > tun0 > > > > > > > > You mean make it more clear in top(1) that tun0 is a process of wiresep? > > > > > > > > What about prefixing all processes with "ws" so that we would get: > > > > root 82906 0.0 0.0 608 1844 ?? Ip Sun11PM 0:00.01 > > > > wsmaster (wiresep) > > > > 3901 8190 0.0 0.1 728 2352 ?? Ip Sun11PM 0:11.39 > > > > wstun0 (wiresep) > > > > 3900 50475 0.0 0.0 672 2072 ?? Ip Sun11PM 0:00.04 > > > > wsproxy (wiresep) > > > > 3900 84443 0.0 0.1 656 2196 ?? Ip Sun11PM 0:00.47 > > > > wsenclave (wiresep) > > > > > > > > > > most daemons that change their proctitle still have the process name > > > first, e.g. > > > > > > wiresep (master), wiresep (tun0), .. > > > > > > or > > > > > > wiresep: master, wiresep: tun0, .. > > > > > > > - the custom rc_check and rc_stop don't seem to be needed, it's better > to just adjust pexp (with .* if necessary) > > - the "underline" in README should be the same number of chars as the > text on the line above > > - rather than the complex > > DISTNAME = ${GH_PROJECT}-${GH_TAGNAME:C/^v//:C/-rc./rc/} > > I think it would be better to let the ports infrastructure handle > DISTNAME and just reset PKGNAME, which then only needs simple subst > rather than regex i.e. PKGNAME = ${DISTNAME:S/-rc./rc/} > >
Forgot to mention, rather than the patch + SUBST_CMD dance, you can just override make variables on the command line; MAKE_FLAGS = PREFIX=${PREFIX} ETCDIR=${SYSCONFDIR}