On Sat, Mar 14 2020, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote:
> On Fri, Mar 13 2020, Paul Irofti <p...@irofti.net> wrote:
>> Hi,
>>
>> Thank you for your effort! I have a few comments and questions.
>
> I got curious about this proposal, mostly because of the COMPILER line
> change.
>
>> I see they switched to Gitlab (hence the url changes) and that the
>> author set it up for continous integration and thus made it compile with
>> clang.
>>
>> Why did you bump the major. I tried browsing the history on Gitlab to
>> see what changed in the API, but couldn't see much. I am sure I missed
>> something.
>
> As shown by /usr/src/lib/check_sym ("No dynamic export changes"), and
> a diff of the installed include file, the shared lib version bump
> appears unnecessary.
>
>> Is the gnuplot bump necessary? Why?
>
> Maybe Yozo found it useful for testing, but it doesn't seem useful for
> the ports tree.
>
> The updated diff below has been stripped from the items that
> I mentioned. It also updates WANTLIB, no need for COMPILER_LIBCXX since
> this is a C-only port. Builds fine on sparc64 along with
> gnuplot,no_x11. Paul, feel free to use the diff below.
Committed, thanks.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
