On Fri, May 22, 2020 at 05:05:38AM +0200, Jan Beich wrote:
> a...@abiscuola.com writes:
>
> > Hi all.
> >
> > I installed the latest snapshot and, suddenly, the microphone
> > stopped working in firefox.
>
> Does it happen since nss 3.52 update? If so ask landry@ to apply
> https://hg.mozilla.org/mozilla-central/rev/463069687b3d
>
> See https://bugzilla.mozilla.org/show_bug.cgi?id=1636632
Well, what a shitshow. I dont use 76 (only 77beta here) and wont have
time to actually test this helps, but if one can confirm the attached
port patch fixes webrtc on 76 (and 68esr, if it's broken) then yes i'll
sure apply it. From my understanding of the FreeBSD bug, it's also
broken on esr ? Can someone test and confirm the patch needs also
backporting there ?
Thanks jan!
Landry
? fx-bug1624128.diff
? notes-sandbox
? patch-configure_py
? patches-cubebremote
? patches-debugvideo
? pledge-59.diff
? wippy3
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/mozilla-firefox/Makefile,v
retrieving revision 1.423
diff -u -r1.423 Makefile
--- Makefile 4 May 2020 14:57:18 -0000 1.423
+++ Makefile 22 May 2020 14:52:18 -0000
@@ -9,6 +9,7 @@
MOZILLA_BRANCH = release
MOZILLA_PROJECT = firefox
MOZILLA_CODENAME = browser
+REVISION = 0
WRKDIST = ${WRKDIR}/${MOZILLA_DIST}-${MOZILLA_DIST_VERSION:C/b[0-9]*//}
HOMEPAGE = https://www.mozilla.org/firefox/
Index: patches/patch-dom_crypto_WebCryptoTask_cpp
===================================================================
RCS file: patches/patch-dom_crypto_WebCryptoTask_cpp
diff -N patches/patch-dom_crypto_WebCryptoTask_cpp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-dom_crypto_WebCryptoTask_cpp 22 May 2020 14:52:18 -0000
@@ -0,0 +1,19 @@
+$OpenBSD$
+
+backport https://hg.mozilla.org/mozilla-central/rev/463069687b3d
+fixes webrtc w/ nss 3.52
+cf https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246363
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1636632
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1624128
+
+Index: dom/crypto/WebCryptoTask.cpp
+--- dom/crypto/WebCryptoTask.cpp.orig
++++ dom/crypto/WebCryptoTask.cpp
+@@ -600,6 +600,7 @@ class AesTask : public ReturnArrayBufferViewTask, publ
+ case CKM_AES_GCM:
+ gcmParams.pIv = mIv.Elements();
+ gcmParams.ulIvLen = mIv.Length();
++ gcmParams.ulIvBits = gcmParams.ulIvLen * 8;
+ gcmParams.pAAD = mAad.Elements();
+ gcmParams.ulAADLen = mAad.Length();
+ gcmParams.ulTagBits = mTagLength;
Index: patches/patch-netwerk_srtp_src_crypto_cipher_aes_gcm_nss_c
===================================================================
RCS file: patches/patch-netwerk_srtp_src_crypto_cipher_aes_gcm_nss_c
diff -N patches/patch-netwerk_srtp_src_crypto_cipher_aes_gcm_nss_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-netwerk_srtp_src_crypto_cipher_aes_gcm_nss_c 22 May 2020
14:52:18 -0000
@@ -0,0 +1,19 @@
+$OpenBSD$
+
+backport https://hg.mozilla.org/mozilla-central/rev/463069687b3d
+fixes webrtc w/ nss 3.52
+cf https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246363
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1636632
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1624128
+
+Index: netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c
+--- netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c.orig
++++ netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c
+@@ -271,6 +271,7 @@ static srtp_err_status_t srtp_aes_gcm_nss_do_crypto(vo
+
+ c->params.pIv = c->iv;
+ c->params.ulIvLen = GCM_IV_LEN;
++ c->params.ulIvBits = GCM_IV_LEN * 8;
+ c->params.pAAD = c->aad;
+ c->params.ulAADLen = c->aad_size;
+
Index: patches/patch-security_manager_ssl_OSKeyStore_cpp
===================================================================
RCS file: patches/patch-security_manager_ssl_OSKeyStore_cpp
diff -N patches/patch-security_manager_ssl_OSKeyStore_cpp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-security_manager_ssl_OSKeyStore_cpp 22 May 2020 14:52:18
-0000
@@ -0,0 +1,19 @@
+$OpenBSD$
+
+backport https://hg.mozilla.org/mozilla-central/rev/463069687b3d
+fixes webrtc w/ nss 3.52
+cf https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246363
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1636632
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1624128
+
+Index: security/manager/ssl/OSKeyStore.cpp
+--- security/manager/ssl/OSKeyStore.cpp.orig
++++ security/manager/ssl/OSKeyStore.cpp
+@@ -663,6 +663,7 @@ nsresult AbstractOSKeyStore::DoCipher(const UniquePK11
+ CK_GCM_PARAMS gcm_params;
+ gcm_params.pIv = const_cast<unsigned char*>(ivp);
+ gcm_params.ulIvLen = mIVLength;
++ gcm_params.ulIvBits = gcm_params.ulIvLen * 8;
+ gcm_params.ulTagBits = 128;
+ gcm_params.pAAD = nullptr;
+ gcm_params.ulAADLen = 0;
Index: patches/patch-third_party_prio_moz_build
===================================================================
RCS file: patches/patch-third_party_prio_moz_build
diff -N patches/patch-third_party_prio_moz_build
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-third_party_prio_moz_build 22 May 2020 14:52:18 -0000
@@ -0,0 +1,20 @@
+$OpenBSD$
+
+backport https://hg.mozilla.org/mozilla-central/rev/463069687b3d
+fixes webrtc w/ nss 3.52
+cf https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246363
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1636632
+cf https://bugzilla.mozilla.org/show_bug.cgi?id=1624128
+
+Index: third_party/prio/moz.build
+--- third_party/prio/moz.build.orig
++++ third_party/prio/moz.build
+@@ -42,3 +42,8 @@ SOURCES += [
+ ]
+
+ FINAL_LIBRARY = 'xul'
++
++# Use PKCS11 v2 struct definitions for now, otherwise NSS requires
++# CK_GCM_PARAMS.ulIvBits to be set. This workaround is only required
++# until NSS 3.52 RTM and upstream correctly initializes the field.
++DEFINES['NSS_PKCS11_2_0_COMPAT'] = True
