On Wed, May 27, 2020 at 01:48:55PM +0900, Masato Asou wrote: > Hi, > > This is a new port sysutils/fluent-bit. Fluent bit is a Log Processor > and Forwarder.
Great stuff, i think i had a look at it some years ago and it looked very-linuxy/not that much portable.. nice that you made it. some notes: * why USE_NINJA=No ? * why not taking maintainership ? * it feels weird to force gmake usage w/ cmake.. in which voodooo trickery does cmake end up generating $< -gmake rules ? cant the cmake stuff be fixed instead ? * 1.4.5 was released 2 days ago * many portability patches without comments.. are you planning to push those upstream via github ? other than that it reads good at first sight. Landry
