From: Landry Breuil <lan...@openbsd.org>
Date: 2020-05-27 5:47:33

> On Wed, May 27, 2020 at 01:48:55PM +0900, Masato Asou wrote:
>> Hi,
>> 
>> This is a new port sysutils/fluent-bit.  Fluent bit is a Log Processor
>> and Forwarder.
> 
> Great stuff, i think i had a look at it some years ago and it looked
> very-linuxy/not that much portable.. nice that you made it.

Thank you.

> some notes:
> * why USE_NINJA=No ?

When I set USE_NINJA=Yes, I got following error:

===>  Configuring for fluent-bit-1.4.4
-- The C compiler identification is Clang 8.0.1
-- The CXX compiler identification is Clang 8.0.1
-- Check for working C compiler: /usr/ports/pobj/fluent-bit-1.4.4/bin/cc
CMake Error:
  The detected version of Ninja (GNU Make 4.3

  Built for x86_64-unknown-openbsd6.7

  Copyright (C) 1988-2020 Free Software Foundation, Inc.

  License GPLv3+: GNU GPL version 3 or later
  <http://gnu.org/licenses/gpl.html>

  This is free software: you are free to change and redistribute it.

  There is NO WARRANTY, to the extent permitted by law.) is less than the
  version of Ninja required by CMake (1.3).


CMake Error at /usr/local/share/cmake/Modules/CMakeTestCCompiler.cmake:44 
(try_compile):
  Failed to generate test project build system.
Call Stack (most recent call first):
  CMakeLists.txt:2 (project)


-- Configuring incomplete, errors occurred!
See also 
"/home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64/CMakeFiles/CMakeOutput.log".
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2746 'do-configure': 
@cd /usr/ports/pobj/fluent-bit-1.4.4/build-amd64 && /usr/bin...)
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2766 
'/usr/ports/pobj/fluent-bit-1.4.4/build-amd64/.configure_done': @cd /usr/por...)
*** Error 2 in /usr/ports/sysutils/fluent-bit 
(/usr/ports/infrastructure/mk/bsd.port.mk:2451 'all': @lock=fluent-bit-1.4.4;  
export _LOCKS_H...)

> * why not taking maintainership ?

There is a way to do it, but I wanted to use it immediately.

> * it feels weird to force gmake usage w/ cmake.. in which voodooo
>   trickery does cmake end up generating $< -gmake rules ?

I got following error:

make -f lib/jsmn/CMakeFiles/jsmn.dir/build.make 
lib/jsmn/CMakeFiles/jsmn.dir/depend
cd /home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64 && 
/usr/local/bin/cmake -E cmake_depends "Unix Makefiles" 
/usr/ports/pobj/fluent-bit-1.4.4/fluent-b
it-1.4.4 /usr/ports/pobj/fluent-bit-1.4.4/fluent-bit-1.4.4/lib/jsmn 
/home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64 
/home/asou/develop/ports/pobj/flue
nt-bit-1.4.4/build-amd64/lib/jsmn 
/home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64/lib/jsmn/CMakeFiles/jsmn.dir/DependInfo.cmake
 --color=
Dependee 
"/home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64/lib/jsmn/CMakeFiles/jsmn.dir/DependInfo.cmake"
 is newer than depender "/home/asou/develop/po
rts/pobj/fluent-bit-1.4.4/build-amd64/lib/jsmn/CMakeFiles/jsmn.dir/depend.internal".
Dependee 
"/home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64/lib/jsmn/CMakeFiles/CMakeDirectoryInformation.cmake"
 is newer than depender "/home/asou/deve
lop/ports/pobj/fluent-bit-1.4.4/build-amd64/lib/jsmn/CMakeFiles/jsmn.dir/depend.internal".
Scanning dependencies of target jsmn
make -f lib/jsmn/CMakeFiles/jsmn.dir/build.make 
lib/jsmn/CMakeFiles/jsmn.dir/build
[  2%] Building C object lib/jsmn/CMakeFiles/jsmn.dir/jsmn.c.o
Using $< in a non-suffix rule context is a GNUmake idiom 
(lib/jsmn/CMakeFiles/jsmn.dir/build.make:63)
*** Error 2 in . (CMakeFiles/Makefile2:2099 'lib/jsmn/CMakeFiles/jsmn.dir/all')
*** Error 2 in /home/asou/develop/ports/pobj/fluent-bit-1.4.4/build-amd64 
(Makefile:152 'all')
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2785 
'/usr/ports/pobj/fluent-bit-1.4.4/build-amd64/.build_done': @cd /usr/ports/p...)
*** Error 2 in /usr/ports/sysutils/fluent-bit 
(/usr/ports/infrastructure/mk/bsd.port.mk:2451 'all': @lock=fluent-bit-1.4.4;  
export _LOCKS_H...)

>  cant the cmake
>   stuff be fixed instead ?

I will look into it.  But I need more time.

> * 1.4.5 was released 2 days ago

I will be able to respond to 1.4.5 soon, maybe.

> * many portability patches without comments..

I will add some comments.

>  are you planning to push
>   those upstream via github ?

Yes I am, if possible.

> other than that it reads good at first sight.

Thank you!


Now, I am confirming the folloeing reply:
> From: Stuart Henderson
> Date: 2020-05-27 10:38:26
> Message-ID: <20200527103826.gj27...@symphytum.spacehopper.org>

--
ASOU Masato

Reply via email to