On Sat, Aug 15, 2020 at 09:39:58PM -0700, Andrew Hewus Fresh wrote: > On Wed, Aug 12, 2020 at 11:15:49AM -0500, Chris Bennett wrote: > > I submitted p5-Plack-Request-WithEncoding-0.13 previously. > > Newer version just went up. Upstream is friendly to changes. > > > > The POD has some problems that cause mandoc errors after noticing that > > the man page looked bad. > > I think that's just the way the pod is written. It seems the author > likes a much wider terminal than I do and so things just wrap weird. > If I pull my terminal out to at least 150 columns it looks better. > > I think the only fix is to reformat the content into something that fits > into a more reasonably sized terminal. > > > > > CX cpb_ports # mandoc -T lint > > /usr/local/man/man3p/Plack::Request::WithEncoding.3p > > mandoc: /usr/local/man/man3p/Plack::Request::WithEncoding.3p:35:1: ERROR: > > escaped character not allowed in a name: br\& > > mandoc: /usr/local/man/man3p/Plack::Request::WithEncoding.3p:136:6: STYLE: > > lower case character in document title: TH Plack::Request::WithEncoding > > > > I'm not familiar enough with POD to man to know what the right change > > is. Upstream accepted my previous documentation changes without a > > problem. > > I'm pretty sure that's just what pod2man outputs, so the fix is probably > unrelated to this particular port. If you run that lint command against > any other 3p manpage and they are pretty much all the same. You don't > get the STYLE warning if the module doesn't have lowercase (for example > URI). > > > > > =================================================================== > > portgen added BUILD_DEPENDS = devel/p5-Module-Build > > but it builds fine without it. > > Should I keep this in Makefile? > > > > # $OpenBSD$ > > > > COMMENT = subclass of Plack::Request which supports encoded requests > > > > DISTNAME = Plack-Request-WithEncoding-0.14 > > > > CATEGORIES = cpan www > > > > # Perl > > PERMIT_PACKAGE = Yes > > > > MODULES = cpan > > > > #BUILD_DEPENDS = devel/p5-Module-Build > > > > RUN_DEPENDS = devel/p5-Hash-MultiValue \ > > www/p5-Plack > > > > TEST_DEPENDS = www/p5-HTTP-Message > > > > MAKE_ENV += TEST_POD=Yes > > > > CONFIGURE_STYLE = modbuild tiny > > > > PKG_ARCH = * > > > > .include <bsd.port.mk> > > > > WIP port attached. > >
Then it just needs the BUILD_DEPENDS line commented out removed? Should I post a copy of that with the change? Thanks, -- Chris Bennett
