On Fri, 02 Sep 2005 18:32:42 +0200, Danny Kukawka wrote: > On Friday 02 September 2005 16:52, Anton Farygin wrote: >> >>>> This is correct ? > > I'm not sure if this is correct to move the code from cpp to header file. > I think we should remove the inline definition and use normal functions > instead of inline.
Why not. Removal inline looks good for me. > > Inline is a replacement for time critical macros and this is also only a > proposal for the compiler. I didn't take a deeper look in the code. Don't > see currently a reason why not use a normal function here. > >> >>> Which state of the CVS? >> >> >> >> HEAD >> >> >> >>> Did the CVS from tag VERSION_10_10_0 works for you? If not, pleas >> >>> send a patch with the changes. Thanks. >> >> >> >> may be VERSION_0_10_10 ? >> >> >> >> Permissions denied for anonymous :-( >> >> >> >> $ cvs up -rVERSION_0_10_10 >> >> Password: cvs [server aborted]: cannot write >> >> /cvsroot/powersave/CVSROOT/val-tags: Permission denied >> > >> > What the ... is that? >> > Anonymous user cannot checkout TAGS? > > Not needed too assign a bug. This need to long until a fix is there. ;) We > should contact them directly. > > The tagged version of (K)powersave is available as tar.bz2 at sf.net. Ok. Thanks. > >> > We need to assign a bug to the forge project ... >> > >> > Could you please send a patch for HEAD then. There shouldn't be any >> > changes in this area recently. >> >> attached. > > Did you tried to remove the inline mark? Yes, without inline functions this code works too. ;) Rgds, Anton _______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
