jacek-lewandowski commented on code in PR #2880:
URL: https://github.com/apache/cassandra/pull/2880#discussion_r1387129592
##########
test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java:
##########
@@ -101,7 +101,7 @@ public class LegacySSTableTest
// Get all versions up to the current one. Useful for testing in
compatibility mode C18301
private static String[] getValidLegacyVersions()
{
- String[] versions = {"oa", "da", "nc", "nb", "na", "me", "md", "mc",
"mb", "ma"};
+ String[] versions = {"oa", "da", "nb", "na", "me", "md", "mc", "mb",
"ma"};
return Arrays.stream(versions).filter((v) ->
v.compareTo(BigFormat.getInstance().getLatestVersion().toString()) <=
0).toArray(String[]::new);
Review Comment:
btw. why is this filtering? It seems like it does not filter anything.
Moreover if feels incorrect as it assumes `BigFormat`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
