bereng commented on code in PR #2880:
URL: https://github.com/apache/cassandra/pull/2880#discussion_r1389125436
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -458,7 +458,7 @@ protected SSTableReader(Builder<?, ?> builder, Owner owner)
this.openReason = builder.getOpenReason();
this.first = builder.getFirst();
this.last = builder.getLast();
- this.bounds = AbstractBounds.strictlyWrapsAround(first.getToken(),
last.getToken())
+ this.bounds = first == null || last == null ||
AbstractBounds.strictlyWrapsAround(first.getToken(), last.getToken())
Review Comment:
Just for future context: DTest
scrub_test.TestScrub.test_standalone_scrub_essential_files_only exercises a
path where we scrub sstables where some of the sstable files are missing. This
can make those vars null so it's a rare but valid code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
