smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r1823333095
##########
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##########
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
}
+ public boolean enabled()
+ {
+ return enabled;
Review Comment:
hah well ... but we can not do that, can we, because every single time we
would ask for "capacity" again which locks ...
basically, we can not ever call "map.capacity()" because it locks, we can
derive it just from DatabaseDescriptor.
##########
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##########
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
}
+ public boolean enabled()
+ {
+ return enabled;
Review Comment:
hah well ... but we can not do that, can we, because every single time we
would ask for "capacity" again which locks, basically, we can not ever call
"map.capacity()" because it locks, we can derive it just from
DatabaseDescriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
