Mmuzaf commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r1824746424
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -1333,7 +1333,7 @@ public void cacheKey(DecoratedKey key, RowIndexEntry info)
{
CachingParams caching = metadata().params.caching;
- if (!caching.cacheKeys() || keyCache == null || keyCache.getCapacity()
== 0)
+ if (!caching.cacheKeys() || keyCache == null || !keyCache.enabled())
Review Comment:
Yes, but I doubt this is a use case - the behaviour is not tested as far as
I can see (the enabled cache with setting capacity to zero). For some of the
cases setting to zero will throw an exception.
If we want to make it runtime configurable then we should rely on DD and
push the change to all the branches we have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
