smiklosovic commented on code in PR #3661:
URL: https://github.com/apache/cassandra/pull/3661#discussion_r1832712104
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -2027,6 +2022,10 @@ public List<String> reloadSeeds()
seeds.addAll(tmp);
// Remove the old entries
seeds.retainAll(tmp);
+
+ if (tmp.contains(getBroadcastAddressAndPort()))
+ seeds.remove(getBroadcastAddressAndPort());
Review Comment:
We can not remove that entry from tmp, because that would render tmp empty
and we ask if tmp.isEmpty(), in that case we just return. But we do not want to
return. Do you see? Because that would return prematurely and we would not
change `seeds`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
