dcapwell commented on code in PR #3661:
URL: https://github.com/apache/cassandra/pull/3661#discussion_r1833224329
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -2023,10 +2018,13 @@ public List<String> reloadSeeds()
return getSeeds();
}
+ tmp.remove(getBroadcastAddressAndPort());
+
// Add the new entries
seeds.addAll(tmp);
// Remove the old entries
seeds.retainAll(tmp);
Review Comment:
so if you only define the self seed, the new logic tries to handle, but then
this step here will make `seeds` empty... I don't really follow why we want to
allow this behavior...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
