maedhroz commented on code in PR #3649:
URL: https://github.com/apache/cassandra/pull/3649#discussion_r1833110199
##########
src/java/org/apache/cassandra/index/sai/plan/StorageAttachedIndexSearcher.java:
##########
@@ -412,15 +433,15 @@ private UnfilteredRowIterator applyIndexFilter(PrimaryKey
key, UnfilteredRowIter
{
queryContext.rowsFiltered++;
- if (tree.isSatisfiedBy(key.partitionKey(), staticRow,
staticRow))
+ if (tree.isSatisfiedBy(partition.partitionKey(), staticRow,
staticRow))
hasMatch = true;
}
if (!hasMatch)
{
// shadowed by expired TTL or row tombstone or range tombstone
if (topK)
- queryContext.vectorContext().recordShadowedPrimaryKey(key);
+
queryContext.vectorContext().recordShadowedPrimaryKey(keys);
Review Comment:
Yeah, that's more or less what I had imagined, modulo fixing it up to avoid
allocations for the topK case, etc.
It's unfortunate that there are no tests that seem to cover this case, and I
don't quite know where to start. Would `VectorUpdateDeleteTest` be a place to
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
