maedhroz commented on code in PR #3649:
URL: https://github.com/apache/cassandra/pull/3649#discussion_r1833148270
##########
src/java/org/apache/cassandra/index/sai/plan/StorageAttachedIndexSearcher.java:
##########
@@ -412,15 +433,15 @@ private UnfilteredRowIterator applyIndexFilter(PrimaryKey
key, UnfilteredRowIter
{
queryContext.rowsFiltered++;
- if (tree.isSatisfiedBy(key.partitionKey(), staticRow,
staticRow))
+ if (tree.isSatisfiedBy(partition.partitionKey(), staticRow,
staticRow))
hasMatch = true;
}
if (!hasMatch)
{
// shadowed by expired TTL or row tombstone or range tombstone
if (topK)
- queryContext.vectorContext().recordShadowedPrimaryKey(key);
+
queryContext.vectorContext().recordShadowedPrimaryKey(keys);
Review Comment:
I'm actually not even sure if we need the explicit static filtering block
after the `while` loop. That block was originally added before CASSANDRA-19034
as an optimization to short-circuit before the `while` loop. Removing it would
make some things simpler. I'm going to try it out and push something...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
