smiklosovic commented on code in PR #3661:
URL: https://github.com/apache/cassandra/pull/3661#discussion_r1833467494
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -1986,20 +1986,15 @@ void buildSeedsList()
/**
* JMX interface for triggering an update of the seed node list.
*/
- public List<String> reloadSeeds()
+ public synchronized List<String> reloadSeeds()
Review Comment:
@jeffjirsa I may go without `synchronized` indeed. I dont think that in
practice it would be problematic to not have it `synchronized`. If somebody
reloads at the same time via different threads then this is not thread safe,
but in practice, that would be true only in case somebody changes the content
of cassandra.yaml for seeds list before the first invocation ends. The
probability of that happening is practically zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
