jeffjirsa commented on code in PR #3661:
URL: https://github.com/apache/cassandra/pull/3661#discussion_r1833461752
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -1986,20 +1986,15 @@ void buildSeedsList()
/**
* JMX interface for triggering an update of the seed node list.
*/
- public List<String> reloadSeeds()
+ public synchronized List<String> reloadSeeds()
Review Comment:
Also note that a TON of people have broken gossip by adding and removing
synchronization. I haven't seen it in the seed path, but elsewhere in
gossiper, folks spent far, far too much time (pre-simulator) on this. If you
touch synchronization in this area, you may want to see if the simulator can
prove it doesn't cause problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
