dcapwell commented on code in PR #136:
URL: https://github.com/apache/cassandra-accord/pull/136#discussion_r1833509020
##########
accord-core/src/main/java/accord/impl/AbstractConfigurationService.java:
##########
@@ -168,15 +196,25 @@ Topology topologyFor(long epoch)
return getOrCreate(epoch).topology;
}
+ Topology topologyForLastReceived()
Review Comment:
I did this as I was planning to just do `synchronized`, but now that
`lastReceived` can be accessed without locks it wasn't needed... kept it as I
still like it but can revert to `epochs.topologyFor(epochs. lastReceived())` if
desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
