belliottsmith commented on PR #136: URL: https://github.com/apache/cassandra-accord/pull/136#issuecomment-2465104499
I think we need all invocations of `ACS.reportTopology` to be invoked without the monitor, so that the monitor is not held when we invoke the listeners. I think `AbstractConfigurationService.reportTopology` should be partially synchronised, but should release the lock before adding any callbacks to futures that may immediately be invoked, and before invoking any listeners. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
