iamaleksey commented on code in PR #3662:
URL: https://github.com/apache/cassandra/pull/3662#discussion_r1834305997
##########
src/java/org/apache/cassandra/schema/SchemaConstants.java:
##########
@@ -62,7 +62,7 @@ public final class SchemaConstants
/* virtual table system keyspace names */
public static final Set<String> VIRTUAL_SYSTEM_KEYSPACE_NAMES =
- ImmutableSet.of(VIRTUAL_VIEWS, VIRTUAL_SCHEMA);
+ ImmutableSet.of(VIRTUAL_SCHEMA, VIRTUAL_VIEWS, VIRTUAL_METRICS,
VIRTUAL_ACCORD_DEBUG);
Review Comment:
I think the sets should include these keyspace names, but we can't make it
conditional without referring to `DatabaseDescriptor` in `SchemaConstants`. And
that would defeat the purpose of `SchemaConstants` (supposed to be usable
without instantiating DD).
From another angle, why not instantiate `system_accord` and
`system_accord_debug` unconditionally? We do expect Accord to be used heavily,
and even for those not using it, there is little harm in those keyspaces being
present but not used. No real harm done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
