ribaraka commented on PR #1770: URL: https://github.com/apache/cassandra-gocql-driver/pull/1770#issuecomment-2468840540
> I noticed that for the `lz4` dependency the approach that was taken was to create its own independent module, if this approach of having it on a separate package is enough should we remove the `lz4` module and make it a package of the "main" module instead? After encountering [an issue with CI](https://github.com/apache/cassandra-gocql-driver/pull/1822) and refactoring `gocql/lz4`, I see little justification for maintaining LZ4 as an independent go module. The `gocql/lz4` module is specifically built to implement the `gocql.Compressor` interface, making it primarily suited for `gocql`. Supporting a separate LZ4 implementation beyond of `gocql` doesn’t add much value and might introduce unnecessary dependencies, increasing both the size and complexity of projects that rely on `gocql`. If it remains independent, it would need to be maintained in alignment with potential external projects, adding to its maintenance complexity without clear benefit to the core `gocql` project. Given that I think, merging `lz4` into `gocql` seems more practical. The merge would simplify dependency management for `gocql` users, reduce the module count, and make the overall structure easier to manage, versioning it independently is unnecessary, eliminate the need for users to manage multiple dependencies and avoid the potential for version incompatibility between `gocql` and `gocql/lz4`. A single, unified `gocql` module would be more user-friendly and streamlined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
