tengu-alt commented on PR #1770: URL: https://github.com/apache/cassandra-gocql-driver/pull/1770#issuecomment-2470558472
> > I would prefer to keep the HostPoolHostPolicy because that provides more consistent naming. > > One reason why I think `hostpool` would be more appropriate is that we're creating this separate package for code that uses the `hostpool` dependency. Let's say we implement something else for gocql that uses this dependency but it's not a hostpolicy, would we add this component to this package or add a new package for it? It would make more sense to add an hypothetical new component that relies on `hostpool` to the existing hostpoolhostpolicy package but now the name of the package wouldn't make sense anymore because it's not only about a hostpolicy. > > `hostpool` would also be more consistent with other packages like `snappy` and `lz4`, instead of `snappycompressor` and `lz4compressor` I see, that makes sense, I will change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
