smiklosovic commented on code in PR #3708:
URL: https://github.com/apache/cassandra/pull/3708#discussion_r1867356244
##########
bin/nodetool:
##########
@@ -52,6 +52,11 @@ if [ -f "$CASSANDRA_CONF/cassandra-env.sh" ]; then
JVM_OPTS="$JVM_OPTS_SAVE"
fi
+# Search cassandra.yaml for jmx port
+if [ -f "$CASSANDRA_CONF/cassandra.yaml" ]; then
+ JMX_PORT=`grep jmx_port $CASSANDRA_CONF/cassandra.yaml | cut -d ':' -f 2 |
tr -d '[[:space:]]'`
Review Comment:
I am OK to drop reading it from yaml, that means reverting this change
altogether. I think it is confusing to parse it from yaml and overriding what
is in `cassandra-env.sh`. I do not think that it is a lot to ask to set that
port in `cassandra-env.sh` if it differs from `cassandra.yaml` and people use
`nodetool`. They are pretty much used to set that in `cassandra-env.sh`
already. JMX will be run in 99.99% cases on 7199 and people can still override
it by hand on nodetool's command line by `-p/--port`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
