smiklosovic commented on code in PR #3708:
URL: https://github.com/apache/cassandra/pull/3708#discussion_r1881876761
##########
src/java/org/apache/cassandra/utils/JMXServerUtils.java:
##########
@@ -176,14 +171,30 @@ private static Map<String, Object>
configureJmxAuthentication()
// before creating the authenticator. If no password file has been
// explicitly set, it's read from the default location
// $JAVA_HOME/lib/management/jmxremote.password
- String configEntry = CASSANDRA_JMX_REMOTE_LOGIN_CONFIG.getString();
+ String configEntry = options.login_config_name;
if (configEntry != null)
{
+ if
(Strings.isNullOrEmpty(CassandraRelevantProperties.JAVA_SECURITY_AUTH_LOGIN_CONFIG.getString()))
+ {
+ if (Strings.isNullOrEmpty(options.login_config_file))
+ {
+ throw new ConfigurationException(String.format("Login
config name %s specified for JMX auth, but no " +
Review Comment:
Sam's thing from his comments in the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
