belliottsmith commented on code in PR #150:
URL: https://github.com/apache/cassandra-accord/pull/150#discussion_r1885117181
##########
accord-core/src/main/java/accord/messages/Commit.java:
##########
@@ -173,64 +174,65 @@ public static void stableAndRead(Node node, Topologies
all, Kind kind, TxnId txn
{
Invariants.checkState(all.oldestEpoch() == txnId.epoch());
Invariants.checkState(all.currentEpoch() == executeAt.epoch());
- Topology executes = all.forEpoch(executeAt.epoch());
- Topology coordinates = all.forEpoch(txnId.epoch());
+ Topology executes = all.getEpoch(executeAt.epoch());
+ Topology coordinates = all.getEpoch(txnId.epoch());
SortedArrayList<Id> contact = all.nodes().without(all::isFaulty);
- sendTo(contact, readSet, (set, id) -> set.contains(id.id), readScope,
node, coordinates, executes, all, kind, Ballot.ZERO,
+ sendTo(contact, readSet, (set, id) -> set.contains(id.id), (set, id)
-> false, readScope, node, coordinates, executes, all, kind, Ballot.ZERO,
Review Comment:
No, but perhaps it is counter-intuitive. If isRead is true, then we always
register a callback (as anything else would make no sense). So we only invoke
the `false` test for non-reads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
