ifesdjeen commented on code in PR #150:
URL: https://github.com/apache/cassandra-accord/pull/150#discussion_r1886562929
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -107,11 +118,11 @@ public static AcceptOutcome recover(SafeCommandStore
safeStore, SafeCommand safe
private static AcceptOutcome preacceptOrRecover(SafeCommandStore
safeStore, SafeCommand safeCommand, StoreParticipants participants, TxnId
txnId, long acceptEpoch, PartialTxn partialTxn, FullRoute<?> route, Ballot
ballot)
{
final Command command = safeCommand.current();
-
if (command.hasBeen(Truncated))
{
logger.trace("{}: skipping preaccept - command is truncated",
txnId);
- return command.is(Invalidated) ? AcceptOutcome.RejectedBallot :
AcceptOutcome.Truncated;
+ return command.is(Invalidated) ? AcceptOutcome.RejectedBallot :
participants.owns().isEmpty()
Review Comment:
Yeah, I thought maybe one top level if and only 1 level of ternary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
