sarankk commented on code in PR #165: URL: https://github.com/apache/cassandra-sidecar/pull/165#discussion_r1894323042
########## server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/AuthorizationWithAdminBypassHandler.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.acl.authorization; + +import java.util.List; + +import io.netty.handler.codec.http.HttpResponseStatus; +import io.vertx.ext.auth.authorization.Authorization; +import io.vertx.ext.web.RoutingContext; +import io.vertx.ext.web.handler.HttpException; +import io.vertx.ext.web.handler.impl.AuthorizationHandlerImpl; + +import static org.apache.cassandra.sidecar.utils.AuthUtils.extractIdentities; + +/** + * Verifies user has required authorizations. Allows admin identities to bypass authorization checks. + */ +public class AuthorizationWithAdminBypassHandler extends AuthorizationHandlerImpl +{ + private final AdminIdentityResolver adminIdentityResolver; + + public AuthorizationWithAdminBypassHandler(AdminIdentityResolver adminIdentityResolver, + Authorization authorization) + { + super(authorization); + this.adminIdentityResolver = adminIdentityResolver; + } + + @Override + public void handle(RoutingContext ctx) + { + List<String> identities = extractIdentities(ctx.user()); + + if (identities.isEmpty()) + { + throw new HttpException(HttpResponseStatus.FORBIDDEN.code(), "Missing client identities"); + } + + // Admin identities bypas route specific authorization checks + if (identities.stream().anyMatch(adminIdentityResolver::isAdmin)) Review Comment: since this stream is not doing any filtering and mapping will leave it as is. Also with `anyMatch` we do not loop through all the identities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
