nvharikrishna commented on code in PR #165:
URL: https://github.com/apache/cassandra-sidecar/pull/165#discussion_r1897442701
##########
server/src/main/java/org/apache/cassandra/sidecar/db/schema/SystemAuthSchema.java:
##########
@@ -66,21 +100,41 @@ protected String tableName()
"tables in system_auth
keyspace");
}
- @Nullable
+ @NotNull
public PreparedStatement selectRoleFromIdentity()
{
+ ensureSchemaAvailable();
Review Comment:
ensureSchemaAvailable is throwing SchemaUnavailableException which is a
runtime exception. While the other methods which return the prepared statements
could return null. Any reason to choose different behavior for these methods?
Can it be made the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
