tengu-alt commented on PR #282: URL: https://github.com/apache/cassandra-website/pull/282#issuecomment-2573151211
@michaelsembwever Thank you for your work! I have taken a look and tested your approach(including the `native-protocol.adoc` autogeneration), and It looks like something will be cool to apply! (I also liked how the tabulation in the `table of contents` looks). Regarding your question about the `.hbs` layout: it manages the logic for inserting versioned page content and navigating within sections using the `table of contents`. This is necessary because, without it, a link to a paragraph within a section might incorrectly navigate to the same paragraph in a previous section. If `native-protocol.adoc` is going to be autogenerated, it would be more reasonable to store the navigation logic within the `process-native-protocol-specs-in-docker.sh` (just need to insert `js` at the end of the `summary file`). >If we agree to put this under reference, the nav bar needs to be fixed/cleaned too… Which one nav bar do you mean? I don't clearly understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
