netudima commented on code in PR #3764:
URL: https://github.com/apache/cassandra/pull/3764#discussion_r1905540153
##########
src/java/org/apache/cassandra/utils/memory/MemoryUtil.java:
##########
@@ -104,54 +104,87 @@ public static void setByte(long address, int count, byte
b)
unsafe.setMemory(address, count, b);
}
+ public static void setShort(long address, short s, boolean isBigEndian)
+ {
+ unsafe.putShort(address, isBigEndian ? Short.reverseBytes(s) : s);
Review Comment:
it was also a place with confused me (like NativeClustering metadata is
written in little-endian and values are in big endian. I will collect data
about the API usage across the logic for analysis to the created ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
