netudima commented on code in PR #3764:
URL: https://github.com/apache/cassandra/pull/3764#discussion_r1905549527
##########
src/java/org/apache/cassandra/utils/FastByteOperations.java:
##########
@@ -70,6 +70,21 @@ public static int compareUnsigned(ByteBuffer b1, ByteBuffer
b2)
return BestHolder.BEST.compare(b1, b2);
}
+ public static int compareUnsigned(ByteBuffer b1, long address2, int
length2)
Review Comment:
I have the following options for the naming in my mind:
1. compareNativeMemoryUnsigned
2. compareMemoryUnsigned
3. compareWithMemoryUnsigned
4. compareWithNativeMemoryUnsigned
do you have any preference or an alternative option here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
