bbotella commented on code in PR #159:
URL: https://github.com/apache/cassandra-sidecar/pull/159#discussion_r1909585372
##########
adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraStorageOperations.java:
##########
@@ -213,4 +214,11 @@ public void outOfRangeDataCleanup(@NotNull String
keyspace, @NotNull String tabl
jmxClient.proxy(StorageJmxOperations.class, STORAGE_SERVICE_OBJ_NAME)
.forceKeyspaceCleanup(concurrency, keyspace, table);
}
+
+ @Override
+ public GossipStatusResponse gossipStatus()
+ {
+ return new
GossipStatusResponse(jmxClient.proxy(StorageJmxOperations.class,
STORAGE_SERVICE_OBJ_NAME)
+ .isGossipRunning() ?
"RUNNING" : "NOT_RUNNING");
Review Comment:
What do you think about moving `"RUNNING"` and `"NOT_RUNNING"` to an enum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
