skoppu22 commented on PR #159:
URL:
https://github.com/apache/cassandra-sidecar/pull/159#issuecomment-2587386791
> Thanks for the contribution.
>
> First of all, please add an entry to `CHANGES.txt`.
>
> Second, the patch is to add an API to check whether gossip is enabled or
disabled in the companion Cassandra node. There are existing health APIs that
check the status of corresponding components. See the following code block for
example.
>
> ```
> GET /api/v1/cassandra/native/__health
> {"status" : "OK | NOT_OK"}
>
> GET /api/v1/cassandra/jmx/__health
> {"status" : "OK | NOT_OK"}
> ```
>
> I think we should be consistent with the existing pattern. In other words,
the API should be this.
>
> ```
> GET /api/v1/cassandra/gossip/__health
> {"status" : "OK | NOT_OK"}
> ```
This API is returning C* gossip thread running status (just tells is gossip
thread running or not). Having thread running doesn't mean gossip health is OK.
So I wouldn't prefer to call it 'gossip health'. Gossip thread may be running,
but gossip state might be not healthy at C* side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
