dcapwell commented on code in PR #3743:
URL: https://github.com/apache/cassandra/pull/3743#discussion_r1917097314
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -1249,14 +1251,17 @@ public CompactionInfo getCompactionInfo()
Int2ObjectHashMap<RedundantBefore> redundantBefores = new
Int2ObjectHashMap<>();
Int2ObjectHashMap<DurableBefore> durableBefores = new
Int2ObjectHashMap<>();
Int2ObjectHashMap<RangesForEpoch> ranges = new Int2ObjectHashMap<>();
-
AsyncChains.getBlockingAndRethrow(node.commandStores().forEach(safeStore -> {
- synchronized (redundantBefores)
- {
- redundantBefores.put(safeStore.commandStore().id(),
safeStore.redundantBefore());
- ranges.put(safeStore.commandStore().id(), safeStore.ranges());
- durableBefores.put(safeStore.commandStore().id(),
safeStore.durableBefore());
- }
- }));
+ if (node.commandStores().all().length > 0)
Review Comment:
this is no longer a true statement (about the test), but its a failure
mode.... if you had accord then migrate away you still have the accord
tables... if compaction runs then we fail without this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
