dcapwell commented on code in PR #3743:
URL: https://github.com/apache/cassandra/pull/3743#discussion_r1913822259
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -403,7 +418,7 @@ public void purge(CommandStores commandStores)
public void replay(CommandStores commandStores)
{
journal.closeCurrentSegmentForTestingIfNonEmpty();
- try (AccordJournalTable.KeyOrderIterator<JournalKey> iter =
journalTable.readAll())
+ try (AccordJournalTable.KeyOrderIterator<JournalKey> iter =
journalTable.readAll(AccordJournalTable.ReadAllIntent.Reply))
Review Comment:
this is less critical after the rebase as the `checkAll` function got
removed... when we are reading for validation we don't want to populate the
index... I left this here to be explicit about this assumption but I can remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
