arjunashok commented on code in PR #166:
URL: https://github.com/apache/cassandra-sidecar/pull/166#discussion_r1927561689


##########
client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java:
##########
@@ -1573,6 +1575,36 @@ public void onError(Throwable throwable)
         assertThat(new String(baos.toByteArray(), 
StandardCharsets.UTF_8)).isEqualTo("Test Content");
     }
 
+    @Test
+    public void testStreamsStats() throws Exception
+    {
+        String streamStatsResponseAsString = "{\"operationMode\":\"NORMAL\"," +
+                                             
"\"streamProgressStats\":{\"totalFilesToReceive\":7," +
+                                             
"\"totalFilesReceived\":7,\"totalBytesToReceive\":15088," +

Review Comment:
   It's a valid point. Although, this API (as it stands today) is a simple 
aggregation (sum) of the stats, so we would need to evaluate the value prop 
testing would provide. We should track that in a separate ticket regardless. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to