yifan-c commented on code in PR #166:
URL: https://github.com/apache/cassandra-sidecar/pull/166#discussion_r1932668770


##########
server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/BasicPermissions.java:
##########
@@ -65,5 +65,5 @@ public class BasicPermissions
     public static final Permission READ_TOPOLOGY = new 
DomainAwarePermission("TOPOLOGY:READ");
 
     // cassandra stats permissions
-    public static final Permission READ_STATS = new 
DomainAwarePermission("STATS:READ");
+    public static final Permission STATS = new StandardPermission("STATS");

Review Comment:
   yeah. It make sense to omit "READ", as read is the only action applicable 
here plausibly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to