tolbertam commented on code in PR #2007:
URL:
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1934156665
##########
core/src/main/java/com/datastax/oss/driver/internal/core/session/PoolManager.java:
##########
@@ -221,18 +222,23 @@ private void init(CqlIdentifier keyspace) {
stateEventFilter.start();
Collection<Node> nodes =
context.getMetadataManager().getMetadata().getNodes().values();
- List<CompletionStage<ChannelPool>> poolStages = new
ArrayList<>(nodes.size());
+ Map<Node, CompletionStage<ChannelPool>> poolStageByNode = new
HashMap<>(nodes.size());
Review Comment:
Wrote a
[test](https://gist.github.com/tolbertam/fe877d03623a6f0392153a5493c1bfb2) to
demonstrate reproducing this, unfortunately I didn't get a chance to validate
the pool behavior:
> On the other side, if we key by EndPoint, then we also need to get by
EndPoint, cause otherwise on requests we risk to not find the desired pool for
the filtered out node instance.
Yeah I think that is inherently the problem. It's not clear to me why
currently it's not actively creating connections for each `Node`. There's
something else I need to understand there so I'm still debugging to better
understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
