tolbertam commented on code in PR #2007:
URL: 
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1934170669


##########
core/src/main/java/com/datastax/oss/driver/internal/core/session/PoolManager.java:
##########
@@ -221,18 +222,23 @@ private void init(CqlIdentifier keyspace) {
       stateEventFilter.start();
 
       Collection<Node> nodes = 
context.getMetadataManager().getMetadata().getNodes().values();
-      List<CompletionStage<ChannelPool>> poolStages = new 
ArrayList<>(nodes.size());
+      Map<Node, CompletionStage<ChannelPool>> poolStageByNode = new 
HashMap<>(nodes.size());

Review Comment:
   I see, looks like there is a problem with my test where it throws an 
UnknownHostException because i'm configuring this wrong. Fixing this up quick:
   
   ```
   10:05:31.474 [s0-admin-1] WARN  c.d.o.d.i.core.pool.ChannelPool - 
[s0|/127.0.0.1:9043]  Error while opening new channel
   java.net.UnknownHostException: /127.0.0.1
        at 
java.base/java.net.InetAddress$CachedAddresses.get(InetAddress.java:797)
        at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1533)
        at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1386)
        at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1307)
        at java.base/java.net.InetAddress.getByName(InetAddress.java:1257)
        at io.netty.util.internal.SocketUtils$8.run(SocketUtils.java:156)
        at io.netty.util.internal.SocketUtils$8.run(SocketUtils.java:153)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at 
io.netty.util.internal.SocketUtils.addressByName(SocketUtils.java:153)
        at 
io.netty.resolver.DefaultNameResolver.doResolve(DefaultNameResolver.java:41)
        at 
io.netty.resolver.SimpleNameResolver.resolve(SimpleNameResolver.java:61)
        at 
io.netty.resolver.SimpleNameResolver.resolve(SimpleNameResolver.java:53)
        at 
io.netty.resolver.InetSocketAddressResolver.doResolve(InetSocketAddressResolver.java:55)
        at 
io.netty.resolver.InetSocketAddressResolver.doResolve(InetSocketAddressResolver.java:31)
        at 
io.netty.resolver.AbstractAddressResolver.resolve(AbstractAddressResolver.java:106)
        at io.netty.bootstrap.Bootstrap.doResolveAndConnect0(Bootstrap.java:206)
        at io.netty.bootstrap.Bootstrap.access$000(Bootstrap.java:46)
        at io.netty.bootstrap.Bootstrap$1.operationComplete(Bootstrap.java:180)
        at io.netty.bootstrap.Bootstrap$1.operationComplete(Bootstrap.java:166)
        at 
io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:590)
        at 
io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:557)
        at 
io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:492)
        at 
io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:636)
        at 
io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:625)
        at 
io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:105)
        at 
io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84)
        at 
io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetSuccess(AbstractChannel.java:990)
        at 
io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:516)
        at 
io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:429)
        at 
io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:486)
        at 
io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
        at 
io.netty.util.concurrent.AbstractEventExecutor.safeExecute$$$capture(AbstractEventExecutor.java:167)
        at 
io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java)
        at 
io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
        at 
io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
        at 
io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to