aweisberg commented on code in PR #3864:
URL: https://github.com/apache/cassandra/pull/3864#discussion_r1940167860
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -1131,6 +1136,8 @@ else if (conditional instanceof Conditional.And)
boolean include(BytesPartitionState partition)
{
if (unmatchable) return false;
+ // did we include a bad partition?
+ if (partition.shouldDelete()) return false;
Review Comment:
`ASTSingleTableModelTest` passes with this line removed
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -765,7 +767,10 @@ private List<PrimaryKey> filter(LookupContext ctx,
List<BytesPartitionState> par
if (partitions.isEmpty()) return Collections.emptyList();
List<PrimaryKey> matches = new ArrayList<>();
for (BytesPartitionState p : partitions)
+ {
+ if (!ctx.include(p)) continue;
Review Comment:
`ASTSingleTableModelTest` passes with this removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
