dcapwell commented on code in PR #3864:
URL: https://github.com/apache/cassandra/pull/3864#discussion_r1940237646
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -765,7 +767,10 @@ private List<PrimaryKey> filter(LookupContext ctx,
List<BytesPartitionState> par
if (partitions.isEmpty()) return Collections.emptyList();
List<PrimaryKey> matches = new ArrayList<>();
for (BytesPartitionState p : partitions)
+ {
+ if (!ctx.include(p)) continue;
Review Comment:
this leads to calling
https://github.com/apache/cassandra/pull/3864/files#r1940167860. This is just
being extra defensive as the write path is supposed to delete the partitions
once `shouldDelete() == true`. This is only here if there exists any other
write path bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
