yifan-c commented on code in PR #188:
URL: https://github.com/apache/cassandra-sidecar/pull/188#discussion_r1945573482
##########
integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##########
@@ -350,6 +351,9 @@ protected Server startSidecarWithInstances(Iterable<?
extends IInstance> instanc
AbstractModule testModule = new IntegrationTestModule(instances,
classLoaderWrapper, mtlsTestHelper,
dnsResolver,
configurationOverrides());
sidecarServerInjector = Guice.createInjector(Modules.override(new
MainModule()).with(testModule));
+ Vertx vertx = sidecarServerInjector.getInstance(Vertx.class);
+ vertx.eventBus()
+
.localConsumer(SidecarServerEvents.ON_SIDECAR_SCHEMA_INITIALIZED.address(), msg
-> sidecarSchemaReadyLatch.countDown());
Review Comment:
register the event consumer at the earliest. The original setup misses the
event occasionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
