yifan-c commented on code in PR #188:
URL: https://github.com/apache/cassandra-sidecar/pull/188#discussion_r1945577219
##########
server/src/test/integration/org/apache/cassandra/sidecar/common/DelegateIntegrationTest.java:
##########
@@ -246,7 +271,7 @@ private void validateJmxConnections(VertxTestContext
context, Set<Integer> jmxCo
}
else if (upInstanceCount == 3)
{
- assertThat(jmxConnectedInstances).containsExactly(1, 2, 3);
+ context.verify(() ->
assertThat(jmxConnectedInstances).containsExactly(1, 2, 3));
Review Comment:
must wrap in the verify block to correctly fail the test if assertion fails.
Otherwise, context/flag are not closed, and test gets stuck until timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
